From: Tomas Krizek <tomas.krizek@nic.cz>
Date: Tue, 20 Nov 2018 16:04:01 +0000 (+0100)
Subject: pytests: parametrize tcp_prefix tests
X-Git-Tag: v3.2.0~18^2~14
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5338934283abad2e53f29eac8e6828170d192d9d;p=thirdparty%2Fknot-resolver.git

pytests: parametrize tcp_prefix tests
---

diff --git a/tests/pytests/test_prefix.py b/tests/pytests/test_prefix.py
index ce19e2745..389ef99d5 100644
--- a/tests/pytests/test_prefix.py
+++ b/tests/pytests/test_prefix.py
@@ -9,21 +9,26 @@ The following test suite focuses on edge cases for the prefix - when it
 is either too short or too long, instead of matching the length of DNS
 message exactly.
 
-The tests with incorrect prefix attempt to sequentially send the incorrect
+The tests with invalid prefix attempt to sequentially send the invalid
 message. After a certain period of time (affected by net.tcp_in_idle,
-TCP_DEFER_ACCEPT, ...), kresd should close the connection.
+TCP_DEFER_ACCEPT, ...), kresd should close the connection. There are
+three variants of these tests - either no valid query is sent, or one
+valid query is sent along with the invalid buffer at once, or one valid
+query is sent and afterwards the invalid buffer is sent.
 """
 
 import time
 
+import pytest
+
 import utils
 
 
-def send_incorrect_repeatedly(sock, buff, delay=1):
+def send_invalid_repeatedly(sock, buff, delay=1):
     """Utility function to keep sending the buffer until MAX_TIMEOUT is reached.
 
     It is expected kresd will close the connection, since the buffer
-    contains incorrect prefix of the message.
+    contains invalid prefix of the message.
 
     If the connection remains open, test is failed.
     """
@@ -35,51 +40,69 @@ def send_incorrect_repeatedly(sock, buff, delay=1):
             time.sleep(delay)
 
 
-def test_prefix_less_than_header(kresd_sock):
+@pytest.fixture(params=[
+    'no_query_before',
+    'send_query_before_invalid',
+    'send_query_before_invalid_single_buffer',
+])
+def send_query_before(request):
+    """This either performs no query, or sends a query along with invalid buffer at once, or
+    sends a query and then the invalid buffer."""
+
+    # pylint: disable=possibly-unused-variable
+
+    def no_query_before(*args, **kwargs):  # pylint: disable=unused-argument
+        pass
+
+    def send_query_before_invalid(sock, invalid_buff, single_buffer=False):
+        """Send an initial query and expect a response."""
+        msg_buff, msgid = utils.get_msgbuff()
+
+        if single_buffer:
+            sock.sendall(msg_buff + invalid_buff)
+        else:
+            sock.sendall(msg_buff)
+            sock.sendall(invalid_buff)
+
+        answer = utils.receive_parse_answer(sock)
+        assert answer.id == msgid
+
+    def send_query_before_invalid_single_buffer(sock, invalid_buff):
+        return send_query_before_invalid(sock, invalid_buff, single_buffer=True)
+
+    return locals()[request.param]
+
+
+def test_prefix_less_than_header(kresd_sock, send_query_before):
     """Prefix is less than the length of the DNS message header."""
     wire, _ = utils.prepare_wire()
     datalen = 11  # DNS header size minus 1
-    buff = utils.prepare_buffer(wire, datalen)
-    send_incorrect_repeatedly(kresd_sock, buff)
+    invalid_buff = utils.prepare_buffer(wire, datalen)
+
+    send_query_before(kresd_sock, invalid_buff)
+    send_invalid_repeatedly(kresd_sock, invalid_buff)
 
 
-def test_prefix_greater_than_message(kresd_sock):
+def test_prefix_greater_than_message(kresd_sock, send_query_before):
     """Prefix is greater than the length of the entire DNS message."""
     wire, _ = utils.prepare_wire()
     datalen = len(wire) + 16
-    buff = utils.prepare_buffer(wire, datalen)
-    send_incorrect_repeatedly(kresd_sock, buff)
+    invalid_buff = utils.prepare_buffer(wire, datalen)
 
+    send_query_before(kresd_sock, invalid_buff)
+    send_invalid_repeatedly(kresd_sock, invalid_buff)
 
-def test_prefix_cuts_message(kresd_sock):
+
+def test_prefix_cuts_message(kresd_sock, send_query_before):
     """Prefix is greater than the length of the DNS message header, but shorter than
     the entire DNS message."""
     wire, _ = utils.prepare_wire()
     datalen = 14  # DNS Header size plus 2
     assert datalen < len(wire)
-    buff = utils.prepare_buffer(wire, datalen)
-    send_incorrect_repeatedly(kresd_sock, buff)
-
-
-def test_prefix_cuts_message_after_ok(kresd_sock):
-    """First, normal DNS message is sent. Afterwards, message with incorrect prefix
-    (greater than header, less than entire message) is sent. First message must be
-    answered, then the connection should be closed after timeout."""
-    normal_wire, normal_msgid = utils.prepare_wire(msgid=1)
-    normal_buff = utils.prepare_buffer(normal_wire)
-
-    cut_wire, _ = utils.prepare_wire(msgid=2)
-    cut_datalen = 14
-    assert cut_datalen < len(cut_wire)
-    cut_buff = utils.prepare_buffer(cut_wire, cut_datalen)
-
-    kresd_sock.sendall(normal_buff)
-    kresd_sock.sendall(cut_buff)
-
-    msg_answer = utils.receive_parse_answer(kresd_sock)
-    assert msg_answer.id == normal_msgid
+    invalid_buff = utils.prepare_buffer(wire, datalen)
 
-    send_incorrect_repeatedly(kresd_sock, cut_buff)
+    send_query_before(kresd_sock, invalid_buff)
+    send_invalid_repeatedly(kresd_sock, invalid_buff)
 
 
 def test_trailing_garbage(kresd_sock):