From: Andy Shevchenko Date: Tue, 25 Nov 2025 09:40:11 +0000 (+0100) Subject: i2c: acpi: Return -ENOENT when no resources found in i2c_acpi_client_count() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5351cf8e96ee149c50fd19a882185907c92934df;p=thirdparty%2Fkernel%2Flinux.git i2c: acpi: Return -ENOENT when no resources found in i2c_acpi_client_count() Some users want to return an error to the upper layers when i2c_acpi_client_count() returns 0. Follow the common pattern in such cases, i.e. return -ENOENT instead of 0. While at it, fix the kernel-doc warning about missing return value description. Signed-off-by: Andy Shevchenko Signed-off-by: Wolfram Sang Signed-off-by: Andi Shyti --- diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c index 2cbd31f77667a..b25e6b04e9d74 100644 --- a/drivers/i2c/i2c-core-acpi.c +++ b/drivers/i2c/i2c-core-acpi.c @@ -84,8 +84,11 @@ static int i2c_acpi_resource_count(struct acpi_resource *ares, void *data) * i2c_acpi_client_count - Count the number of I2cSerialBus resources * @adev: ACPI device * - * Returns the number of I2cSerialBus resources in the ACPI-device's + * Return: + * The number of I2cSerialBus resources in the ACPI-device's * resource-list; or a negative error code. + * + * Specifically returns -ENOENT when no resources found. */ int i2c_acpi_client_count(struct acpi_device *adev) { @@ -97,7 +100,7 @@ int i2c_acpi_client_count(struct acpi_device *adev) return ret; acpi_dev_free_resource_list(&r); - return count; + return count ?: -ENOENT; } EXPORT_SYMBOL_GPL(i2c_acpi_client_count);