From: Thomas Markwalder <tmark@isc.org>
Date: Tue, 7 Jul 2026 17:14:33 +0000 (-0400)
Subject: [#4587] Addressed review comments
X-Git-Tag: Kea-3.3.0~87
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5359f338222e6f9e04e700f75082807287c69d80;p=thirdparty%2Fkea.git

[#4587] Addressed review comments

minor clean ups

modified:   src/lib/dns/tests/rdata_unittest.cc
modified:   src/lib/util/str.h
---

diff --git a/src/lib/dns/tests/rdata_unittest.cc b/src/lib/dns/tests/rdata_unittest.cc
index d076ca1855..9ea41c6346 100644
--- a/src/lib/dns/tests/rdata_unittest.cc
+++ b/src/lib/dns/tests/rdata_unittest.cc
@@ -255,19 +255,10 @@ protected:
 string
 Rdata_Unknown_Test::getLongestRdataTxt() {
     ostringstream oss;
-
     oss << "\\# " << MAX_RDLENGTH << " ";
-#if 0
-    static_cast<void>(oss.fill('0'));
-    oss << right << hex;
-    for (unsigned i = 0; i < MAX_RDLENGTH; i++) {
-        oss << setw(2) << (i & 0xff);
-    }
-#else
     for (unsigned i = 0; i < MAX_RDLENGTH; i++) {
         oss << str::byteToHex(i);
     }
-#endif
 
     return (oss.str());
 }
diff --git a/src/lib/util/str.h b/src/lib/util/str.h
index d49c383dc5..aa3a199dfc 100644
--- a/src/lib/util/str.h
+++ b/src/lib/util/str.h
@@ -288,13 +288,13 @@ dumpAsHex(const uint8_t* data, size_t length);
 
 /// @brief Dumps a vector of bytes as a string of hexadecimal digits.
 ///
-/// @param vec vector to dump
+/// @param vec vector to dump.
 std::string
 dumpAsHex(const std::vector<uint8_t>& vec);
 
 /// @brief Dumps a string as a string of hexadecimal digits.
 ///
-/// @param str string to dump
+/// @param str string to dump.
 std::string
 dumpAsHex(const std::string& str);