From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Tue, 31 Jan 2023 16:12:53 +0000 (+0200)
Subject: lib-http: Remove unnecessary NULL check
X-Git-Tag: 2.4.0~3022
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=537f5c77a9f55dad3bbb26c0896c4deb6b89b975;p=thirdparty%2Fdovecot%2Fcore.git

lib-http: Remove unnecessary NULL check

This is confusing static analyzers.

Broken by 987fab8f4e143ab851c3318c8614e81bb0f2b360
---

diff --git a/src/lib-http/http-client-request.c b/src/lib-http/http-client-request.c
index 7e578a6186..81a78bcc54 100644
--- a/src/lib-http/http-client-request.c
+++ b/src/lib-http/http-client-request.c
@@ -1073,8 +1073,7 @@ http_client_request_finish_payload_out(struct http_client_request *req)
 		o_stream_unref(&req->payload_output);
 		req->payload_output = NULL;
 	}
-	if (conn->conn.output != NULL &&
-	    o_stream_get_buffer_used_size(conn->conn.output) > 0) {
+	if (o_stream_get_buffer_used_size(conn->conn.output) > 0) {
 		e_debug(req->event,
 			"Not quite finished sending request");
 		conn->output_locked = TRUE;