From: James Jones <jejones3141@gmail.com>
Date: Wed, 14 Jun 2023 16:15:09 +0000 (-0500)
Subject: Help coverity see validation of field_len (#5059)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5390bcbf05528d514a6058d40a0259b00bd61447;p=thirdparty%2Ffreeradius-server.git

Help coverity see validation of field_len (#5059)
---

diff --git a/src/protocols/tacacs/decode.c b/src/protocols/tacacs/decode.c
index b4c6a1c9260..bc5884892ac 100644
--- a/src/protocols/tacacs/decode.c
+++ b/src/protocols/tacacs/decode.c
@@ -374,7 +374,7 @@ static int tacacs_decode_field(TALLOC_CTX *ctx, fr_pair_list_t *out, fr_dict_att
 	uint8_t const *p = *field_data;
 	fr_pair_t *vp;
 
-	if ((p + field_len) > end) {
+	if (field_len > (end - p)) {
 		fr_strerror_printf("'%s' length %u overflows the remaining data (%zu) in the packet",
 				   da->name, field_len, end - p);
 		return -1;