From: Frédéric Buclin <LpSolit@gmail.com>
Date: Thu, 28 Apr 2011 14:48:59 +0000 (+0200)
Subject: Bug 653404: Misleading error message when file to be attached is not readable by... 
X-Git-Tag: bugzilla-4.0.2~49
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=539f8c3af846dc67962f1ddbd904a0c049ac3df0;p=thirdparty%2Fbugzilla.git

Bug 653404: Misleading error message when file to be attached is not readable by browser
r=glob a=LpSolit
---

diff --git a/attachment.cgi b/attachment.cgi
index d1836ca92b..8c73f425a0 100755
--- a/attachment.cgi
+++ b/attachment.cgi
@@ -476,10 +476,13 @@ sub insert {
     # Must be called before create() as it may alter $cgi->param('ispatch').
     my $content_type = Bugzilla::Attachment::get_content_type();
 
+    # Get the filehandle of the attachment.
+    my $data_fh = $cgi->upload('data');
+
     my $attachment = Bugzilla::Attachment->create(
         {bug           => $bug,
          creation_ts   => $timestamp,
-         data          => scalar $cgi->param('attachurl') || $cgi->upload('data'),
+         data          => scalar $cgi->param('attachurl') || $data_fh,
          description   => scalar $cgi->param('description'),
          filename      => $cgi->param('attachurl') ? '' : scalar $cgi->upload('data'),
          ispatch       => scalar $cgi->param('ispatch'),