From: Sean Bright <sean.bright@gmail.com>
Date: Mon, 25 Mar 2019 19:31:23 +0000 (-0400)
Subject: chan_sip: Ensure 'qualifygap' isn't negative
X-Git-Tag: 13.26.0-rc1~6^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=53aa750839e63d5c9804dfc25e5e0c2ac7f405ea;p=thirdparty%2Fasterisk.git

chan_sip: Ensure 'qualifygap' isn't negative

Passing negative intervals to the scheduler rips a hole in the
space-time continuum.

ASTERISK-25792 #close
Reported by: Paul Sandys

Change-Id: Ie706f21cee05f76ffb6f7d89e9c867930ee7bcd7
---

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index ac922fa8b5..ce88e52557 100644
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -32900,7 +32900,8 @@ static int reload_config(enum channelreloadreason reason)
 				ast_log(LOG_WARNING, "Usage of SIP_CAUSE is deprecated.  Please use HANGUPCAUSE instead.\n");
 			}
 		} else if (!strcasecmp(v->name, "qualifygap")) {
-			if (sscanf(v->value, "%30d", &global_qualify_gap) != 1) {
+			if (sscanf(v->value, "%30d", &global_qualify_gap) != 1
+				|| global_qualify_gap < 0) {
 				ast_log(LOG_WARNING, "Invalid qualifygap '%s' at line %d of %s\n", v->value, v->lineno, config);
 				global_qualify_gap = DEFAULT_QUALIFY_GAP;
 			}