From: Willy Tarreau Date: Tue, 23 Jul 2013 15:39:02 +0000 (+0200) Subject: MEDIUM: counters: factor out smp_fetch_sc*_kbytes_out X-Git-Tag: v1.5-dev20~304 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=53aea10fe9835e59c40cb4aef29ff32b95e82e97;p=thirdparty%2Fhaproxy.git MEDIUM: counters: factor out smp_fetch_sc*_kbytes_out smp_fetch_sc0_kbytes_out, smp_fetch_sc1_kbytes_out, smp_fetch_sc2_kbytes_out, smp_fetch_src_kbytes_out and smp_fetch_kbytes_out were merged into a single function which relies on the fetch name to decide what to return. --- diff --git a/src/session.c b/src/session.c index 48cb9b02af..4eab98be4c 100644 --- a/src/session.c +++ b/src/session.c @@ -3047,16 +3047,24 @@ smp_fetch_sc_bytes_in_rate(struct proxy *px, struct session *l4, void *l7, unsig return 1; } -/* set temp integer to the number of kbytes sent to clients matching the stksess entry */ +/* set to the number of kbytes sent to clients, as found in the + * session's tracked frontend counters. Supports being called as + * "sc[0-9]_kbytes_out" or "src_kbytes_out" only. + */ static int -smp_fetch_kbytes_out(struct stktable *table, struct sample *smp, struct stksess *ts) +smp_fetch_sc_kbytes_out(struct proxy *px, struct session *l4, void *l7, unsigned int opt, + const struct arg *args, struct sample *smp, const char *kw) { + struct stkctr *stkctr = smp_fetch_sc_stkctr(l4, args, kw); + + if (!stkctr) + return 0; + smp->flags = SMP_F_VOL_TEST; smp->type = SMP_T_UINT; smp->data.uint = 0; - - if (ts != NULL) { - void *ptr = stktable_data_ptr(table, ts, STKTABLE_DT_BYTES_OUT_CNT); + if (stkctr->entry != NULL) { + void *ptr = stktable_data_ptr(stkctr->table, stkctr->entry, STKTABLE_DT_BYTES_OUT_CNT); if (!ptr) return 0; /* parameter not stored */ smp->data.uint = stktable_data_cast(ptr, bytes_out_cnt) >> 10; @@ -3064,63 +3072,6 @@ smp_fetch_kbytes_out(struct stktable *table, struct sample *smp, struct stksess return 1; } -/* set temp integer to the number of kbytes sent to clients according to the session's - * tracked FE counters. - */ -static int -smp_fetch_sc0_kbytes_out(struct proxy *px, struct session *l4, void *l7, unsigned int opt, - const struct arg *args, struct sample *smp, const char *kw) -{ - if (!l4->stkctr[0].entry) - return 0; - - return smp_fetch_kbytes_out(l4->stkctr[0].table, smp, l4->stkctr[0].entry); -} - -/* set temp integer to the number of kbytes sent to clients according to the session's - * tracked BE counters. - */ -static int -smp_fetch_sc1_kbytes_out(struct proxy *px, struct session *l4, void *l7, unsigned int opt, - const struct arg *args, struct sample *smp, const char *kw) -{ - if (!l4->stkctr[1].entry) - return 0; - - return smp_fetch_kbytes_out(l4->stkctr[1].table, smp, l4->stkctr[1].entry); -} - -/* set temp integer to the number of kbytes sent to clients according to the session's - * tracked BE counters. - */ -static int -smp_fetch_sc2_kbytes_out(struct proxy *px, struct session *l4, void *l7, unsigned int opt, - const struct arg *args, struct sample *smp, const char *kw) -{ - if (!l4->stkctr[2].entry) - return 0; - - return smp_fetch_kbytes_out(l4->stkctr[2].table, smp, l4->stkctr[2].entry); -} - -/* set temp integer to the number of kbytes sent to the session's source address in - * the table pointed to by expr. - * Accepts exactly 1 argument of type table. - */ -static int -smp_fetch_src_kbytes_out(struct proxy *px, struct session *l4, void *l7, unsigned int opt, - const struct arg *args, struct sample *smp, const char *kw) -{ - struct stktable_key *key; - - key = addr_to_stktable_key(&l4->si[0].conn->addr.from); - if (!key) - return 0; - - px = args->data.prx; - return smp_fetch_kbytes_out(&px->table, smp, stktable_lookup_key(&px->table, key)); -} - /* set temp integer to the bytes rate to clients in the stksess entry over the * configured period. */ @@ -3282,7 +3233,7 @@ static struct sample_fetch_kw_list smp_fetch_keywords = {ILH, { { "sc0_http_req_rate", smp_fetch_sc_http_req_rate, 0, NULL, SMP_T_UINT, SMP_USE_INTRN, }, { "sc0_inc_gpc0", smp_fetch_sc_inc_gpc0, 0, NULL, SMP_T_UINT, SMP_USE_INTRN, }, { "sc0_kbytes_in", smp_fetch_sc_kbytes_in, 0, NULL, SMP_T_UINT, SMP_USE_L4CLI, }, - { "sc0_kbytes_out", smp_fetch_sc0_kbytes_out, 0, NULL, SMP_T_UINT, SMP_USE_L4CLI, }, + { "sc0_kbytes_out", smp_fetch_sc_kbytes_out, 0, NULL, SMP_T_UINT, SMP_USE_L4CLI, }, { "sc0_sess_cnt", smp_fetch_sc_sess_cnt, 0, NULL, SMP_T_UINT, SMP_USE_INTRN, }, { "sc0_sess_rate", smp_fetch_sc_sess_rate, 0, NULL, SMP_T_UINT, SMP_USE_INTRN, }, { "sc0_tracked", smp_fetch_sc_tracked, 0, NULL, SMP_T_BOOL, SMP_USE_INTRN, }, @@ -3301,7 +3252,7 @@ static struct sample_fetch_kw_list smp_fetch_keywords = {ILH, { { "sc1_http_req_rate", smp_fetch_sc_http_req_rate, 0, NULL, SMP_T_UINT, SMP_USE_INTRN, }, { "sc1_inc_gpc0", smp_fetch_sc_inc_gpc0, 0, NULL, SMP_T_UINT, SMP_USE_INTRN, }, { "sc1_kbytes_in", smp_fetch_sc_kbytes_in, 0, NULL, SMP_T_UINT, SMP_USE_L4CLI, }, - { "sc1_kbytes_out", smp_fetch_sc1_kbytes_out, 0, NULL, SMP_T_UINT, SMP_USE_L4CLI, }, + { "sc1_kbytes_out", smp_fetch_sc_kbytes_out, 0, NULL, SMP_T_UINT, SMP_USE_L4CLI, }, { "sc1_sess_cnt", smp_fetch_sc_sess_cnt, 0, NULL, SMP_T_UINT, SMP_USE_INTRN, }, { "sc1_sess_rate", smp_fetch_sc_sess_rate, 0, NULL, SMP_T_UINT, SMP_USE_INTRN, }, { "sc1_tracked", smp_fetch_sc_tracked, 0, NULL, SMP_T_BOOL, SMP_USE_INTRN, }, @@ -3320,7 +3271,7 @@ static struct sample_fetch_kw_list smp_fetch_keywords = {ILH, { { "sc2_http_req_rate", smp_fetch_sc_http_req_rate, 0, NULL, SMP_T_UINT, SMP_USE_INTRN, }, { "sc2_inc_gpc0", smp_fetch_sc_inc_gpc0, 0, NULL, SMP_T_UINT, SMP_USE_INTRN, }, { "sc2_kbytes_in", smp_fetch_sc_kbytes_in, 0, NULL, SMP_T_UINT, SMP_USE_L4CLI, }, - { "sc2_kbytes_out", smp_fetch_sc2_kbytes_out, 0, NULL, SMP_T_UINT, SMP_USE_L4CLI, }, + { "sc2_kbytes_out", smp_fetch_sc_kbytes_out, 0, NULL, SMP_T_UINT, SMP_USE_L4CLI, }, { "sc2_sess_cnt", smp_fetch_sc_sess_cnt, 0, NULL, SMP_T_UINT, SMP_USE_INTRN, }, { "sc2_sess_rate", smp_fetch_sc_sess_rate, 0, NULL, SMP_T_UINT, SMP_USE_INTRN, }, { "sc2_tracked", smp_fetch_sc_tracked, 0, NULL, SMP_T_BOOL, SMP_USE_INTRN, }, @@ -3339,7 +3290,7 @@ static struct sample_fetch_kw_list smp_fetch_keywords = {ILH, { { "src_http_req_rate", smp_fetch_sc_http_req_rate, ARG1(1,TAB), NULL, SMP_T_UINT, SMP_USE_L4CLI, }, { "src_inc_gpc0", smp_fetch_sc_inc_gpc0, ARG1(1,TAB), NULL, SMP_T_UINT, SMP_USE_L4CLI, }, { "src_kbytes_in", smp_fetch_sc_kbytes_in, ARG1(1,TAB), NULL, SMP_T_UINT, SMP_USE_L4CLI, }, - { "src_kbytes_out", smp_fetch_src_kbytes_out, ARG1(1,TAB), NULL, SMP_T_UINT, SMP_USE_L4CLI, }, + { "src_kbytes_out", smp_fetch_sc_kbytes_out, ARG1(1,TAB), NULL, SMP_T_UINT, SMP_USE_L4CLI, }, { "src_sess_cnt", smp_fetch_sc_sess_cnt, ARG1(1,TAB), NULL, SMP_T_UINT, SMP_USE_L4CLI, }, { "src_sess_rate", smp_fetch_sc_sess_rate, ARG1(1,TAB), NULL, SMP_T_UINT, SMP_USE_L4CLI, }, { "src_updt_conn_cnt", smp_fetch_src_updt_conn_cnt, ARG1(1,TAB), NULL, SMP_T_UINT, SMP_USE_L4CLI, },