From: Niels Dossche <niels.dossche@ugent.be>
Date: Tue, 17 Jan 2023 19:27:49 +0000 (+0100)
Subject: Fix incorrect error return value in i2r_ADMISSION_SYNTAX()
X-Git-Tag: openssl-3.2.0-alpha1~1443
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=53b5d6c30f3b8eaf7a582da2265c0d1cfe14d54f;p=thirdparty%2Fopenssl.git

Fix incorrect error return value in i2r_ADMISSION_SYNTAX()

The other implementations of i2r return 0 in case of an error, but
i2r_ADMISSION_SYNTAX() returns -1. That means the check on i2r does not
catch the error. Change it to return 0 like the others do.

Fixes: #20066

CLA: trivial

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/20068)
---

diff --git a/crypto/x509/v3_admis.c b/crypto/x509/v3_admis.c
index cd875e9dd14..7aa8a4a4200 100644
--- a/crypto/x509/v3_admis.c
+++ b/crypto/x509/v3_admis.c
@@ -199,7 +199,7 @@ static int i2r_ADMISSION_SYNTAX(const struct v3_ext_method *method, void *in,
     return 1;
 
 err:
-    return -1;
+    return 0;
 }
 
 const ASN1_OBJECT *NAMING_AUTHORITY_get0_authorityId(const NAMING_AUTHORITY *n)