From: Marin Hannache <git@mareo.fr>
Date: Thu, 18 Jul 2013 12:35:30 +0000 (+0200)
Subject: [nfs] Fix an issue with the selection of a local port
X-Git-Tag: v1.20.1~1438
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=53c01d6444d9e7d5b420c65e9486e990960aba45;p=thirdparty%2Fipxe.git

[nfs] Fix an issue with the selection of a local port

Reported-by: Robin Smidsrød <robin@smidsrod.no>
Signed-off-by: Marin Hannache <git@mareo.fr>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
---

diff --git a/src/net/oncrpc/nfs_open.c b/src/net/oncrpc/nfs_open.c
index ff2b7404a..349957ffe 100644
--- a/src/net/oncrpc/nfs_open.c
+++ b/src/net/oncrpc/nfs_open.c
@@ -160,12 +160,12 @@ static int nfs_connect ( struct interface *intf, uint16_t port,
 		return -EINVAL;
 
 	memset ( &peer, 0, sizeof ( peer ) );
-	memset ( &peer, 0, sizeof ( local ) );
+	memset ( &local, 0, sizeof ( local ) );
 	peer.st_port = htons ( port );
 
 	/* Use a local port < 1024 to avoid using the 'insecure' option in
 	 * /etc/exports file. */
-	local.st_port = htons ( 1 + ( rand() % 1023 ) );
+	local.st_flags = TCPIP_BIND_PRIVILEGED;
 
 	return xfer_open_named_socket ( intf, SOCK_STREAM,
 	                                ( struct sockaddr * ) &peer, hostname,