From: Andrew Bartlett <abartlet@samba.org>
Date: Wed, 22 Nov 2023 02:01:47 +0000 (+1300)
Subject: ldb/pyldb: Check errors from PyLdbMessage_FromMessage
X-Git-Tag: tdb-1.4.11~1545
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=53cdfff711aa43d8294648fee209351aaace75aa;p=thirdparty%2Fsamba.git

ldb/pyldb: Check errors from PyLdbMessage_FromMessage

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/lib/ldb/pyldb.c b/lib/ldb/pyldb.c
index 20b3c26f958..982828549d5 100644
--- a/lib/ldb/pyldb.c
+++ b/lib/ldb/pyldb.c
@@ -381,7 +381,13 @@ static PyObject *PyLdbResult_FromResult(struct ldb_result *result)
 	}
 
 	for (i = 0; i < result->count; i++) {
-		PyList_SetItem(list, i, PyLdbMessage_FromMessage(result->msgs[i]));
+		PyObject *pymessage = PyLdbMessage_FromMessage(result->msgs[i]);
+		if (pymessage == NULL) {
+			Py_DECREF(ret);
+			Py_DECREF(list);
+			return NULL;
+		}
+		PyList_SetItem(list, i, pymessage);
 	}
 
 	ret->mem_ctx = talloc_new(NULL);