From: Ralph Boehme Date: Tue, 1 May 2018 07:53:36 +0000 (+0200) Subject: s3:cleanupd: sends MSG_SMB_UNLOCK twice to interested peers X-Git-Tag: ldb-1.4.0~434 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=53ff08a2cf838c0f1c3f050ac2aa13fc3acc5981;p=thirdparty%2Fsamba.git s3:cleanupd: sends MSG_SMB_UNLOCK twice to interested peers MSG_SMB_UNLOCK should be send to smbd that are waiting on blocked byte-range-locks when a lock holder died. In smbd_cleanupd_unlock() we do this twice: once via a broadcast and then again via brl_revalidate() to processes that are actually recorded in brlock.tdb. As brl_revalidate() should already take care of signaling anyone who would be interested in the message, there's no need to broadcast. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13416 Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Fri May 4 03:02:28 CEST 2018 on sn-devel-144 --- diff --git a/source3/smbd/smbd_cleanupd.c b/source3/smbd/smbd_cleanupd.c index a9b1e8a1137..6ed87207925 100644 --- a/source3/smbd/smbd_cleanupd.c +++ b/source3/smbd/smbd_cleanupd.c @@ -98,8 +98,6 @@ static void smbd_cleanupd_unlock(struct messaging_context *msg, DBG_WARNING("Cleaning up brl and lock database after unclean " "shutdown\n"); - messaging_send_all(msg, MSG_SMB_UNLOCK, NULL, 0); - brl_revalidate(msg, private_data, msg_type, server_id, data); }