From: Naveen Albert <asterisk@phreaknet.org>
Date: Sun, 24 Oct 2021 11:55:50 +0000 (+0000)
Subject: sig_analog: Fix truncated buffer copy
X-Git-Tag: 19.1.0-rc1~65
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=53fff3ec7cb8aebf660ecc819714d89ef565ddf8;p=thirdparty%2Fasterisk.git

sig_analog: Fix truncated buffer copy

Fixes compiler warning caused by a truncated copy of the ANI2 into a
buffer of size 10. This could prevent the null terminator from being
copied if the copy value exceeds the size of the buffer. This increases
the buffer size to 101 to ensure there is no way for truncation to occur.

ASTERISK-29702 #close

Change-Id: Ief9052212952840fa44de6463b8699fdb3e163d0
---

diff --git a/channels/sig_analog.c b/channels/sig_analog.c
index 5bb5649b78..1af56e7451 100644
--- a/channels/sig_analog.c
+++ b/channels/sig_analog.c
@@ -1967,7 +1967,7 @@ static void *__analog_ss_thread(void *data)
 			 * this as a complete spill for the purposes of setting anistart */
 			if ((res > 0) || (strlen(anibuf) >= 2)) {
 				char anistart[2] = "X";
-				char f[10] = {0};
+				char f[101] = {0};
 				if (strchr("#ABC", anibuf[strlen(anibuf) - 1])) {
 					anistart[0] = anibuf[strlen(anibuf) - 1];
 					anibuf[strlen(anibuf) - 1] = 0;