From: lpsolit%gmail.com <>
Date: Fri, 2 Sep 2005 04:52:20 +0000 (+0000)
Subject: Bug 298306: For new products, the charting error message "The tool which gathers... 
X-Git-Tag: bugzilla-2.21.1~53
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5432b26b7479c9b90c1e172d285f02c00c173870;p=thirdparty%2Fbugzilla.git

Bug 298306: For new products, the charting error message "The tool which gathers bug counts has not been run yet" is misleading - Patch by Marc Schumann <wurblzap@gmail.com> r=gerv a=myk
---

diff --git a/reports.cgi b/reports.cgi
index 49948e2bb2..7274ea8e2b 100755
--- a/reports.cgi
+++ b/reports.cgi
@@ -253,7 +253,11 @@ sub generate_chart {
     my ($data_file, $image_file, $type, $product, $datasets) = @_;
     
     if (! open FILE, $data_file) {
-        ThrowCodeError("chart_data_not_generated");
+        if ($product eq '-All-') {
+            $product = '';
+        }
+
+        ThrowCodeError("chart_data_not_generated", {'product' => $product});
     }
 
     my @fields;
diff --git a/template/en/default/global/code-error.html.tmpl b/template/en/default/global/code-error.html.tmpl
index f11b27b0a7..b459fa44a3 100644
--- a/template/en/default/global/code-error.html.tmpl
+++ b/template/en/default/global/code-error.html.tmpl
@@ -70,8 +70,18 @@
     the error [% bug.error FILTER html %].
     
   [% ELSIF error == "chart_data_not_generated" %]
-    The tool which gathers [% terms.bug %] counts has not been run yet.
-        
+    [% IF product %]
+      Charts for the <em>[% product FILTER html %]</em> product are not
+      available yet because no charting data has been collected for it since it
+      was created.
+    [% ELSE %]
+      No charting data has been collected yet.
+    [% END %]
+    Please wait a day and try again.
+    If you're seeing this message after a day, then you should contact
+    <a href="mailto:[% Param('maintainer') %]">[% Param('maintainer') %]</a>
+    and reference this error.
+
   [% ELSIF error == "chart_datafile_corrupt" %]
     The chart data file [% file FILTER html %] is corrupt.