From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Tue, 7 Mar 2023 20:24:49 +0000 (+1300)
Subject: s4/dsdb/repl_meta_data: Pass NULL into ldb_msg_add_empty
X-Git-Tag: talloc-2.4.1~1355
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=545b40a70b02141ed292ddd3ff63d1f62070bb85;p=thirdparty%2Fsamba.git

s4/dsdb/repl_meta_data: Pass NULL into ldb_msg_add_empty

We weren't doing anything with the passed-in 'el' afterwards, so this
was just confusing.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
index 175a02d3ba7..cb32d190dce 100644
--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
@@ -4712,7 +4712,7 @@ static int replmd_delete_internals(struct ldb_module *module, struct ldb_request
 				 */
 				dsdb_flags |= DSDB_REPLMD_VANISH_LINKS;
 			}
-			ret = ldb_msg_add_empty(msg, el->name, LDB_FLAG_MOD_DELETE, &el);
+			ret = ldb_msg_add_empty(msg, el->name, LDB_FLAG_MOD_DELETE, NULL);
 			if (ret != LDB_SUCCESS) {
 				talloc_free(tmp_ctx);
 				ldb_module_oom(module);