From: mkanat%bugzilla.org <>
Date: Fri, 17 Apr 2009 21:57:35 +0000 (+0000)
Subject: Bug 488467: Verify and Login auth methods were being called in a random order, c
X-Git-Tag: bugzilla-3.4rc1~43
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=54634ad46a3e3759bdc0cf1f7e7043789189bbef;p=thirdparty%2Fbugzilla.git

Bug 488467: Verify and Login auth methods were being called in a random order, c
ausing sudo sessions to frequently not need the user to re-enter their password.
Patch by Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=LpSolit
---

diff --git a/Bugzilla/Auth/Login/Stack.pm b/Bugzilla/Auth/Login/Stack.pm
index ab9a93bce9..a5752f22bb 100644
--- a/Bugzilla/Auth/Login/Stack.pm
+++ b/Bugzilla/Auth/Login/Stack.pm
@@ -38,7 +38,7 @@ sub new {
     Bugzilla::Hook::process('auth-login_methods', { modules => \%methods });
 
     $self->{_stack} = [];
-    foreach my $login_method (keys %methods) {
+    foreach my $login_method (split(',', $list)) {
         my $module = $methods{$login_method};
         require $module;
         $module =~ s|/|::|g;
diff --git a/Bugzilla/Auth/Verify/Stack.pm b/Bugzilla/Auth/Verify/Stack.pm
index 0ddb9a441d..c23b532fdf 100644
--- a/Bugzilla/Auth/Verify/Stack.pm
+++ b/Bugzilla/Auth/Verify/Stack.pm
@@ -33,7 +33,7 @@ sub new {
     Bugzilla::Hook::process('auth-verify_methods', { modules => \%methods });
 
     $self->{_stack} = [];
-    foreach my $verify_method (keys %methods) {
+    foreach my $verify_method (split(',', $list)) {
         my $module = $methods{$verify_method};
         require $module;
         $module =~ s|/|::|g;