From: Laine Stump <laine@laine.org>
Date: Fri, 17 Mar 2017 21:49:45 +0000 (-0400)
Subject: util: allow retrieving ethtool features when unprivileged
X-Git-Tag: v3.2.0-rc1~189
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=549fe5a882ceab37cf2cb2c4550033670478d824;p=thirdparty%2Flibvirt.git

util: allow retrieving ethtool features when unprivileged

The only reason that the ethtool features weren't being retrieved in
an unprivileged libvirtd was because they required ioctl(), and the
ioctl was using an AF_PACKET socket, which requires root. Now that we
are using AF_UNIX for ioctl(), this restriction can be removed.
---

diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index acc6c2ea7e..9e52a1f725 100644
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -2583,12 +2583,6 @@ virNetDevGetFeatures(const char *ifname,
     if (!(*out = virBitmapNew(VIR_NET_DEV_FEAT_LAST)))
         return -1;
 
-    /* Only fetch features if we're privileged, but no need to fail */
-    if (geteuid() != 0) {
-        VIR_DEBUG("ETHTOOL feature bits not available in session mode");
-        return 0;
-    }
-
     if ((fd = virNetDevSetupControl(ifname, &ifr)) < 0)
         goto cleanup;