From: Daniel Stenberg <daniel@haxx.se>
Date: Tue, 17 Dec 2024 10:08:13 +0000 (+0100)
Subject: checksrc: fix the return() checker
X-Git-Tag: curl-8_12_0~327
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=54c5cb8b7feb72870051ee932695e8769203821d;p=thirdparty%2Fcurl.git

checksrc: fix the return() checker

It would previously wrongly also catch function calls to function names
ending with 'return'

Amended test1185.

Reported-by: Stefan Eissing
Closes #15764
---

diff --git a/scripts/checksrc.pl b/scripts/checksrc.pl
index 4e3e05050f..d17f953144 100755
--- a/scripts/checksrc.pl
+++ b/scripts/checksrc.pl
@@ -714,7 +714,7 @@ sub scanfile {
         }
 
         # check for "return(" without space
-        if($l =~ /^(.*)return\(/) {
+        if($l =~ /^(.*\W)return\(/) {
             if($1 =~ / *\#/) {
                 # this is a #if, treat it differently
             }
diff --git a/tests/data/test1185 b/tests/data/test1185
index c3133aa23b..daea3101c8 100644
--- a/tests/data/test1185
+++ b/tests/data/test1185
@@ -46,7 +46,7 @@ if(a == 2){ /* followed by comment */
   ;
 }
 
-func() ;
+func_return() ;
 
 a = sprintf(buffer, "%s", moo);
 
@@ -120,9 +120,9 @@ void startfunc(int a, int b) {
 ./%LOGDIR/code1185.c:24:11: warning: missing space after close paren (PARENBRACE)
  if(a == 2){  
            ^
-./%LOGDIR/code1185.c:28:7: warning: no space before semicolon (SPACESEMICOLON)
- func() ;
-       ^
+./%LOGDIR/code1185.c:28:14: warning: no space before semicolon (SPACESEMICOLON)
+ func_return() ;
+              ^
 ./%LOGDIR/code1185.c:30:5: warning: use of sprintf is banned (BANNEDFUNC)
  a = sprintf(buffer, "%s", moo);
      ^