From: Alan T. DeKok <aland@freeradius.org>
Date: Fri, 30 Aug 2019 15:36:45 +0000 (-0400)
Subject: fall through if there's no error
X-Git-Tag: release_3_0_20~83
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=54d6cc2cf9a8fa868e4c2f3ea56aefad09f7c5ea;p=thirdparty%2Ffreeradius-server.git

fall through if there's no error
---

diff --git a/src/main/tls.c b/src/main/tls.c
index 6072072fced..db733996661 100644
--- a/src/main/tls.c
+++ b/src/main/tls.c
@@ -3940,12 +3940,12 @@ fr_tls_status_t tls_application_data(tls_session_t *ssn, REQUEST *request)
 		code = SSL_get_error(ssn->ssl, err);
 		switch (code) {
 		case SSL_ERROR_WANT_READ:
-			DEBUG("Error in fragmentation logic: SSL_WANT_READ");
+			RDEBUG("Error in fragmentation logic: SSL_WANT_READ");
 			return FR_TLS_MORE_FRAGMENTS;
 
 		case SSL_ERROR_WANT_WRITE:
-			DEBUG("Error in fragmentation logic: SSL_WANT_WRITE");
-			break;
+			RDEBUG("Error in fragmentation logic: SSL_WANT_WRITE");
+			return FR_TLS_FAIL;
 
 		case SSL_ERROR_NONE:
 			RDEBUG2("No application data received.  Assuming handshake is continuing...");
@@ -3956,9 +3956,8 @@ fr_tls_status_t tls_application_data(tls_session_t *ssn, REQUEST *request)
 			REDEBUG("Error in fragmentation logic");
 			tls_error_io_log(request, ssn, err,
 					 "Failed in " STRINGIFY(__FUNCTION__) " (SSL_read)");
-			break;
+			return FR_TLS_FAIL;
 		}
-		return FR_TLS_FAIL;
 	}
 
 	/*