From: Eric Wong <e@80x24.org>
Date: Mon, 30 Sep 2024 21:30:07 +0000 (+0000)
Subject: xt/solver: use `psgi' shortcut for require_mods()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=550b87b5397453f03df889df0733f0164ab102e9;p=thirdparty%2Fpublic-inbox.git

xt/solver: use `psgi' shortcut for require_mods()

The `psgi' shortcut simplifies setup, reduces the likelyhood
of human error from omitted modules, and avoid needless `use_ok'
tests which make the output noisier than necessary.
---

diff --git a/xt/solver.t b/xt/solver.t
index 372d003b2..d074b1b52 100644
--- a/xt/solver.t
+++ b/xt/solver.t
@@ -4,9 +4,7 @@
 use v5.12;
 use PublicInbox::TestCommon;
 use PublicInbox::Config; # this relies on PI_CONFIG // ~/.public-inbox/config
-my @psgi = qw(HTTP::Request::Common Plack::Test URI::Escape Plack::Builder);
-require_mods(qw(DBD::SQLite Xapian), @psgi);
-use_ok($_) for @psgi;
+require_mods qw(DBD::SQLite Xapian psgi);
 use_ok 'PublicInbox::WWW';
 my $cfg = PublicInbox::Config->new;
 my $www = PublicInbox::WWW->new($cfg);