From: James Jones <jejones3141@gmail.com>
Date: Thu, 5 May 2022 21:56:46 +0000 (-0500)
Subject: fr_strerror_clear() needn't bother with fr_strerror_init() (CID #1503892) (#4486)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5517ed19ca059735b07049542a9ea96ded9f3201;p=thirdparty%2Ffreeradius-server.git

fr_strerror_clear() needn't bother with fr_strerror_init() (CID #1503892) (#4486)

fr_strerror_clear() already refers to fr_strerror_buffer, and might as
well use it rather than the return value from fr_sterror_init().
---

diff --git a/src/lib/util/strerror.c b/src/lib/util/strerror.c
index 90224ef60d5..5ffe513e271 100644
--- a/src/lib/util/strerror.c
+++ b/src/lib/util/strerror.c
@@ -538,11 +538,10 @@ char const *fr_strerror(void)
  */
 void fr_strerror_clear(void)
 {
-	fr_log_buffer_t		*buffer;
+	fr_log_buffer_t		*buffer = fr_strerror_buffer;
 
-	if (unlikely(!fr_strerror_buffer)) return;
+	if (unlikely(!buffer)) return;
 
-	buffer = fr_strerror_init();
 	fr_dlist_clear(&buffer->entries);
 	talloc_free_children(buffer->pool_a);
 	talloc_free_children(buffer->pool_b);