From: Czarnowska, Anna <anna.czarnowska@intel.com>
Date: Thu, 17 Feb 2011 22:46:00 +0000 (+0000)
Subject: fix: memory leak in Create
X-Git-Tag: mdadm-3.2.1~105
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=55425f279ca20b43c151eaf0bc08e6882eef746e;p=thirdparty%2Fmdadm.git

fix: memory leak in Create

match_metadata_desc allocates memory for st
which is not needed after validate_geometry fails

Signed-off-by: Anna Czarnowska <anna.czarnowska@intel.com>
Signed-off-by: NeilBrown <neilb@suse.de>
---

diff --git a/Create.c b/Create.c
index a0669fe0..ccda07b8 100644
--- a/Create.c
+++ b/Create.c
@@ -309,8 +309,10 @@ int Create(struct supertype *st, char *mddev,
 				if (st && !st->ss->validate_geometry
 					    	(st, level, layout, raiddisks,
 						 chunk, size*2, dname, &freesize,
-						 verbose > 0))
+						 verbose > 0)) {
+					free(st);
 					st = NULL;
+				}
 			}
 
 			if (!st) {