From: David Malcolm <dmalcolm@redhat.com>
Date: Thu, 29 May 2025 20:57:52 +0000 (-0400)
Subject: diagnostics: bulletproof html_builder::make_metadata_element
X-Git-Tag: basepoints/gcc-17~7831
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=554d2a2f0e200607dcdfbf15328800bc1c21e2fd;p=thirdparty%2Fgcc.git

diagnostics: bulletproof html_builder::make_metadata_element

gcc/ChangeLog:
	* diagnostic-format-html.cc (html_builder::make_metadata_element):
	Gracefully handle the case where "url" is null.

Signed-off-by: David Malcolm <dmalcolm@redhat.com>
---

diff --git a/gcc/diagnostic-format-html.cc b/gcc/diagnostic-format-html.cc
index f2b255bf9cd..3fa5e662d2b 100644
--- a/gcc/diagnostic-format-html.cc
+++ b/gcc/diagnostic-format-html.cc
@@ -897,10 +897,14 @@ html_builder::make_metadata_element (label_text label,
   xml::printer xp (*item.get ());
   xp.add_text ("[");
   {
-    xp.push_tag ("a", true);
-    xp.set_attr ("href", url.get ());
+    if (url.get ())
+      {
+	xp.push_tag ("a", true);
+	xp.set_attr ("href", url.get ());
+      }
     xp.add_text (label.get ());
-    xp.pop_tag ();
+    if (url.get ())
+      xp.pop_tag ();
   }
   xp.add_text ("]");
   return item;