From: Ian Lance Taylor Date: Tue, 7 Jan 2020 15:35:04 +0000 (+0000) Subject: compiler: avoid write barrier for a[i] = a[i][:v] X-Git-Tag: misc/cutover-git~120 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5561b41dd67630273479d7661638c5c36a5abb5b;p=thirdparty%2Fgcc.git compiler: avoid write barrier for a[i] = a[i][:v] This avoids generating a write barrier for code that appears in the Go1.14beta1 runtime package in (*pageAlloc).sysGrow: s.summary[l] = s.summary[l][:needIdxLimit] Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/213558 From-SVN: r279962 --- diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE index 6dca40fe31aa..9f825daa5fe5 100644 --- a/gcc/go/gofrontend/MERGE +++ b/gcc/go/gofrontend/MERGE @@ -1,4 +1,4 @@ -d0a102eea2262e3fca89b1eb342fd03328c4aa16 +86d223eaccecff72b44cd23a014bc028b658055e The first line of this file holds the git revision number of the last merge done from the gofrontend repository. diff --git a/gcc/go/gofrontend/expressions.cc b/gcc/go/gofrontend/expressions.cc index 8d72b1f478ca..c228905eb5eb 100644 --- a/gcc/go/gofrontend/expressions.cc +++ b/gcc/go/gofrontend/expressions.cc @@ -183,6 +183,24 @@ Expression::is_same_variable(Expression* a, Expression* b) bu->operand())); } + Array_index_expression* aie = a->array_index_expression(); + if (aie != NULL) + { + Array_index_expression* bie = b->array_index_expression(); + return (aie->end() == NULL + && bie->end() == NULL + && Expression::is_same_variable(aie->array(), bie->array()) + && Expression::is_same_variable(aie->start(), bie->start())); + } + + Numeric_constant aval; + if (a->numeric_constant_value(&aval)) + { + Numeric_constant bval; + if (b->numeric_constant_value(&bval)) + return aval.equals(bval); + } + return false; }