From: Ralph Boehme <slow@samba.org>
Date: Fri, 10 Sep 2021 05:13:48 +0000 (+0200)
Subject: smbtree: don't ignore unknown options
X-Git-Tag: ldb-2.5.0~702
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5562674a2188d4e11fbdfcbed7bf1fba02af9e90;p=thirdparty%2Fsamba.git

smbtree: don't ignore unknown options

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14828

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source3/utils/smbtree.c b/source3/utils/smbtree.c
index 6e38b6eb5f2..4719640033a 100644
--- a/source3/utils/smbtree.c
+++ b/source3/utils/smbtree.c
@@ -102,6 +102,7 @@ int main(int argc, char *argv[])
 	struct smbc_dirent *dirent = NULL;
 	bool ok;
 	int ret, result = 1;
+	int opt;
 	int debuglevel;
 
 	/* Initialise samba stuff */
@@ -129,7 +130,16 @@ int main(int argc, char *argv[])
 		exit(1);
 	}
 
-	while(poptGetNextOpt(pc) != -1);
+	while((opt = poptGetNextOpt(pc)) != -1) {
+		switch (opt) {
+		case POPT_ERROR_BADOPT:
+			fprintf(stderr, "\nInvalid option %s: %s\n\n",
+				poptBadOption(pc, 0), poptStrerror(opt));
+			poptPrintUsage(pc, stderr, 0);
+			exit(1);
+		}
+	}
+
 	samba_cmdline_burn(argc, argv);
 
 	debuglevel = DEBUGLEVEL;