From: Martin Kletzander <mkletzan@redhat.com>
Date: Mon, 1 Jul 2013 07:23:04 +0000 (+0200)
Subject: qemu: Don't miss errors when changing graphics passwords
X-Git-Tag: CVE-2013-2230~76
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=556808ec9deae8623aea2a3a8c1c80a62a335c4a;p=thirdparty%2Flibvirt.git

qemu: Don't miss errors when changing graphics passwords

Commit 23e8b5d8e7a92bac85b7fd2aca8992501bf680ee forgot to check the
return value for all calls to qemuDomainChangeGraphicsPasswords().
---

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 4fe343c02c..df0ac722a8 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -2055,10 +2055,10 @@ qemuProcessInitPasswords(virConnectPtr conn,
                                                     &graphics->data.spice.auth,
                                                     cfg->spicePassword);
         }
-    }
 
-    if (ret < 0)
-        goto cleanup;
+        if (ret < 0)
+            goto cleanup;
+    }
 
     if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE)) {
         for (i = 0; i < vm->def->ndisks; i++) {