From: Roger Dingledine <arma@torproject.org>
Date: Fri, 12 Sep 2003 06:18:38 +0000 (+0000)
Subject: serious bug in cpuworker. need to think about redesign or how to handle it.
X-Git-Tag: tor-0.0.2pre8~20
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=556bea4b6d807099e90a3f0c6615d7e500b83424;p=thirdparty%2Ftor.git

serious bug in cpuworker. need to think about redesign or how to handle it.


svn:r448
---

diff --git a/src/or/cpuworker.c b/src/or/cpuworker.c
index 0b92733f2b..9d88afab6e 100644
--- a/src/or/cpuworker.c
+++ b/src/or/cpuworker.c
@@ -55,6 +55,7 @@ int connection_cpu_process_inbuf(connection_t *conn) {
 
     connection_fetch_from_buf(buf,LEN_ONION_RESPONSE,conn);
 
+    /* XXX conn->circ might already have been closed. Serious bug. Suck. */
     if(*buf == 0 || conn->circ->p_conn == NULL ||
        onionskin_process(conn->circ, buf+1, buf+1+DH_KEY_LEN) < 0) {
       log_fn(LOG_DEBUG,"decoding onion, onionskin_process, or p_conn failed. Closing.");