From: Christophe Jaillet <jailletc36@apache.org>
Date: Mon, 6 Jan 2020 21:29:42 +0000 (+0000)
Subject: In winnt_accept() (server/mpm/winnt/child.c), there's a call to PostQueuedCompletionS... 
X-Git-Tag: 2.5.0-alpha2-ci-test-only~1718
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=556fdf0dd34b1678ae254ca5dd3f41cf7832235c;p=thirdparty%2Fapache%2Fhttpd.git

In winnt_accept() (server/mpm/winnt/child.c), there's a call to PostQueuedCompletionStatus() with a buffer (BytesRead) for the number of bytes read.

When compiling the code with Visual Studio 2019 (v 16.3.10), we get a warning than BytesRead is not initialized. When using /RTCu (run-time checks for uninitialzed variables), the program crashes on this line with an exception.

If we initialize the variable to 0, the problem is solved.

PR 63965

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1872394 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/server/mpm/winnt/child.c b/server/mpm/winnt/child.c
index d752b825ff2..fd63cfc6668 100644
--- a/server/mpm/winnt/child.c
+++ b/server/mpm/winnt/child.c
@@ -365,7 +365,7 @@ static unsigned int __stdcall winnt_accept(void *lr_)
     ap_listen_rec *lr = (ap_listen_rec *)lr_;
     apr_os_sock_info_t sockinfo;
     winnt_conn_ctx_t *context = NULL;
-    DWORD BytesRead;
+    DWORD BytesRead = 0;
     SOCKET nlsd;
     LPFN_ACCEPTEX lpfnAcceptEx = NULL;
     LPFN_GETACCEPTEXSOCKADDRS lpfnGetAcceptExSockaddrs = NULL;