From: John Ferlan <jferlan@redhat.com>
Date: Fri, 5 May 2017 21:21:50 +0000 (-0400)
Subject: test: Add testStorageVolDefFindByName for storage volume tests
X-Git-Tag: v3.6.0-rc1~84
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=55b1f1aabac2d718ab2a5cc631c59365610d251a;p=thirdparty%2Flibvirt.git

test: Add testStorageVolDefFindByName for storage volume tests

Remove repetitive code, replace with common function.

Signed-off-by: John Ferlan <jferlan@redhat.com>
---

diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 9abc203fee..45e9adc8ba 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -4830,9 +4830,24 @@ testStoragePoolListAllVolumes(virStoragePoolPtr pool,
 }
 
 
+static virStorageVolDefPtr
+testStorageVolDefFindByName(virStoragePoolObjPtr obj,
+                            const char *name)
+{
+    virStorageVolDefPtr privvol;
+
+    if (!(privvol = virStorageVolDefFindByName(obj, name))) {
+        virReportError(VIR_ERR_NO_STORAGE_VOL,
+                       _("no storage vol with matching name '%s'"), name);
+    }
+
+    return privvol;
+}
+
+
 static virStorageVolPtr
 testStorageVolLookupByName(virStoragePoolPtr pool,
-                           const char *name ATTRIBUTE_UNUSED)
+                           const char *name)
 {
     testDriverPtr privconn = pool->conn->privateData;
     virStoragePoolObjPtr obj;
@@ -4842,13 +4857,8 @@ testStorageVolLookupByName(virStoragePoolPtr pool,
     if (!(obj = testStoragePoolObjFindActiveByName(privconn, pool->name)))
         return NULL;
 
-    privvol = virStorageVolDefFindByName(obj, name);
-
-    if (!privvol) {
-        virReportError(VIR_ERR_NO_STORAGE_VOL,
-                       _("no storage vol with matching name '%s'"), name);
+    if (!(privvol = testStorageVolDefFindByName(obj, name)))
         goto cleanup;
-    }
 
     ret = virGetStorageVol(pool->conn, obj->def->name,
                            privvol->name, privvol->key,
@@ -5077,14 +5087,8 @@ testStorageVolDelete(virStorageVolPtr vol,
     if (!(obj = testStoragePoolObjFindActiveByName(privconn, vol->pool)))
         return -1;
 
-    privvol = virStorageVolDefFindByName(obj, vol->name);
-
-    if (privvol == NULL) {
-        virReportError(VIR_ERR_NO_STORAGE_VOL,
-                       _("no storage vol with matching name '%s'"),
-                       vol->name);
+    if (!(privvol = testStorageVolDefFindByName(obj, vol->name)))
         goto cleanup;
-    }
 
     obj->def->allocation -= privvol->target.allocation;
     obj->def->available = (obj->def->capacity - obj->def->allocation);
@@ -5132,14 +5136,8 @@ testStorageVolGetInfo(virStorageVolPtr vol,
     if (!(obj = testStoragePoolObjFindActiveByName(privconn, vol->pool)))
         return -1;
 
-    privvol = virStorageVolDefFindByName(obj, vol->name);
-
-    if (privvol == NULL) {
-        virReportError(VIR_ERR_NO_STORAGE_VOL,
-                       _("no storage vol with matching name '%s'"),
-                       vol->name);
+    if (!(privvol = testStorageVolDefFindByName(obj, vol->name)))
         goto cleanup;
-    }
 
     memset(info, 0, sizeof(*info));
     info->type = testStorageVolumeTypeForPool(obj->def->type);
@@ -5167,14 +5165,8 @@ testStorageVolGetXMLDesc(virStorageVolPtr vol,
     if (!(obj = testStoragePoolObjFindActiveByName(privconn, vol->pool)))
         return NULL;
 
-    privvol = virStorageVolDefFindByName(obj, vol->name);
-
-    if (privvol == NULL) {
-        virReportError(VIR_ERR_NO_STORAGE_VOL,
-                       _("no storage vol with matching name '%s'"),
-                       vol->name);
+    if (!(privvol = testStorageVolDefFindByName(obj, vol->name)))
         goto cleanup;
-    }
 
     ret = virStorageVolDefFormat(obj->def, privvol);
 
@@ -5195,14 +5187,8 @@ testStorageVolGetPath(virStorageVolPtr vol)
     if (!(obj = testStoragePoolObjFindActiveByName(privconn, vol->pool)))
         return NULL;
 
-    privvol = virStorageVolDefFindByName(obj, vol->name);
-
-    if (privvol == NULL) {
-        virReportError(VIR_ERR_NO_STORAGE_VOL,
-                       _("no storage vol with matching name '%s'"),
-                       vol->name);
+    if (!(privvol = testStorageVolDefFindByName(obj, vol->name)))
         goto cleanup;
-    }
 
     ignore_value(VIR_STRDUP(ret, privvol->target.path));