From: Theodore Ts'o Date: Wed, 17 Apr 2024 17:58:49 +0000 (-0400) Subject: debugfs: fix clang warnings X-Git-Tag: v1.47.1-rc1~47 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=55bc5ce40648e4df91c019b05fbfcc9c5b803c10;p=thirdparty%2Fe2fsprogs.git debugfs: fix clang warnings Signed-off-by: Theodore Ts'o --- diff --git a/debugfs/set_fields.c b/debugfs/set_fields.c index ef137b0f..6755f880 100644 --- a/debugfs/set_fields.c +++ b/debugfs/set_fields.c @@ -456,7 +456,8 @@ static errcode_t parse_uint(struct field_set_info *info, char *field, int suffix = check_suffix(field); char *tmp; void *field1 = info->ptr, *field2 = info->ptr2; - int size = (info->size == 6 || info->size == 5) ? 4 : info->size; + unsigned int size = (info->size == 6 || info->size == 5) ? 4 : + info->size; union { __u64 *ptr64; __u32 *ptr32; @@ -484,7 +485,7 @@ static errcode_t parse_uint(struct field_set_info *info, char *field, } mask = ~0ULL >> ((8 - size) * 8); limit = ~0ULL >> ((8 - info->size) * 8); - if (field2 && (info->size != 6 || info->size != 5)) + if (field2 && (info->size != 6 && info->size != 5)) limit = ~0ULL >> ((8 - info->size*2) * 8); if (num > limit) {