From: Jelmer Vernooij <jelmer@samba.org>
Date: Mon, 29 Sep 2008 17:09:53 +0000 (+0200)
Subject: Avoid freeing fsp twice when opening new_file fails. (Debian #431696)
X-Git-Tag: samba-4.0.0alpha6~769^2~228^2~105
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=55e201b0a1b24e328b718b78ab8fa926bcc9e90b;p=thirdparty%2Fsamba.git

Avoid freeing fsp twice when opening new_file fails. (Debian #431696)
If opening new_file fails, fsp would still be set to the files_struct of
old_file.
---

diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c
index ded985c260d..a3b3a1021fc 100644
--- a/source3/printing/nt_printing.c
+++ b/source3/printing/nt_printing.c
@@ -1377,6 +1377,7 @@ static int file_version_is_newer(connection_struct *conn, fstring new_file, fstr
 		}
 	}
 	close_file(fsp, NORMAL_CLOSE);
+	fsp = NULL;
 
 	/* Get file version info (if available) for new file */
 	filepath = driver_unix_convert(conn,new_file,&stat_buf);