From: Sean Bright <sean.bright@gmail.com>
Date: Thu, 13 Dec 2018 21:56:50 +0000 (-0500)
Subject: res_format_attr_h264.c: Make sure profile-level-id fmtp attribute is set
X-Git-Tag: 13.25.0-rc1~35^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=560747dca4ac0dbc46c543812a38c6b8e926fc21;p=thirdparty%2Fasterisk.git

res_format_attr_h264.c: Make sure profile-level-id fmtp attribute is set

The profile-iop octet (the 2nd) of profile-level-id can be zero
according to RFC 6184 Section 8.1. So we ignore its value when deciding
to include profile-level-id in the outgoing SDP.

ASTERISK-27959 #close
Reported by: David Kuehling

Change-Id: Id28cd916a3d7748058fe9609b585d07d9e243f73
---

diff --git a/res/res_format_attr_h264.c b/res/res_format_attr_h264.c
index 702a13e676..d5b9138d7f 100644
--- a/res/res_format_attr_h264.c
+++ b/res/res_format_attr_h264.c
@@ -284,7 +284,7 @@ static void h264_generate_sdp_fmtp(const struct ast_format *format, unsigned int
 	APPEND_IF_NOT_H264_UNSET(attr->PACKETIZATION_MODE, str, "packetization-mode");
 	APPEND_IF_NOT_H264_UNSET(attr->LEVEL_ASYMMETRY_ALLOWED, str, "level-asymmetry-allowed");
 
-	if (attr->PROFILE_IDC && attr->PROFILE_IOP && attr->LEVEL) {
+	if (attr->PROFILE_IDC && attr->LEVEL) {
 		if (added) {
 			ast_str_append(str, 0, ";");
 		} else if (0 < ast_str_append(str, 0, "a=fmtp:%u ", payload)) {