From: Jim Meyering <meyering@redhat.com>
Date: Mon, 17 May 2010 10:10:52 +0000 (+0200)
Subject: qemu_driver: avoid NULL dereference
X-Git-Tag: v0.8.2~278
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=560758c90034e5c8658db74c7a9e7cbb9391a4d6;p=thirdparty%2Flibvirt.git

qemu_driver: avoid NULL dereference

* src/qemu/qemu_driver.c (qemudDomainStart): After setting vm to NULL,
goto cleanup, rather than dereferencing the NULL pointer.
---

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index fabd41b95c..5f1d6b59f4 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -6489,8 +6489,11 @@ static int qemudDomainStart(virDomainPtr dom) {
          * We should still have a reference left to vm but
          * one should check for 0 anyway
          */
-        if (qemuDomainObjEndJob(vm) == 0)
+        if (qemuDomainObjEndJob(vm) = 0) {
             vm = NULL;
+            goto cleanup;
+        }
+
         virDomainObjUnlock(vm);
         qemuDriverUnlock(driver);
         ret = qemudDomainRestore(dom->conn, managed_save);