From: Theodore Ts'o <tytso@mit.edu>
Date: Tue, 7 Jan 2014 14:18:19 +0000 (-0500)
Subject: badblocks: print warning if set_o_direct() fails
X-Git-Tag: v1.42.10~124
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=56087556e12275b47afd24254451320a837a1d19;p=thirdparty%2Fe2fsprogs.git

badblocks: print warning if set_o_direct() fails

Addresses-Coverity-Id: #1049148

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---

diff --git a/misc/badblocks.c b/misc/badblocks.c
index 912ef2863..e5024f6c6 100644
--- a/misc/badblocks.c
+++ b/misc/badblocks.c
@@ -300,7 +300,8 @@ static void set_o_direct(int dev, unsigned char *buffer, size_t size,
 		flag = fcntl(dev, F_GETFL);
 		if (flag > 0) {
 			flag = (flag & ~O_DIRECT) | new_flag;
-			fcntl(dev, F_SETFL, flag);
+			if (fcntl(dev, F_SETFL, flag) < 0)
+				perror("set_o_direct");
 		}
 		current_O_DIRECT = new_flag;
 	}