From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 28 Oct 2005 23:06:42 +0000 (+0000)
Subject: (savedir): Don't assume that xrealloc etc. leave errno alone.
X-Git-Tag: v6.0~1451
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5648577df01d1f210790aaeec645c767137316eb;p=thirdparty%2Fcoreutils.git

(savedir): Don't assume that xrealloc etc. leave errno alone.
---

diff --git a/lib/ChangeLog b/lib/ChangeLog
index 87e3d88ad7..1dd26ac7a4 100644
--- a/lib/ChangeLog
+++ b/lib/ChangeLog
@@ -1,3 +1,8 @@
+2005-10-28  Paul Eggert  <eggert@cs.ucla.edu>
+
+	* savedir.c (savedir): Don't assume that xrealloc etc. leave
+	errno alone.  Problem reported by Frederic Jolliton.
+
 2005-10-24  Jim Meyering  <jim@meyering.net>
 
 	* mkdir-p.c (make_dir_parents): Like the code above, don't rely
diff --git a/lib/savedir.c b/lib/savedir.c
index a2cf2f6787..86930eb569 100644
--- a/lib/savedir.c
+++ b/lib/savedir.c
@@ -70,7 +70,6 @@ char *
 savedir (const char *dir)
 {
   DIR *dirp;
-  struct dirent *dp;
   char *name_space;
   size_t allocated = NAME_SIZE_DEFAULT;
   size_t used = 0;
@@ -82,12 +81,19 @@ savedir (const char *dir)
 
   name_space = xmalloc (allocated);
 
-  errno = 0;
-  while ((dp = readdir (dirp)) != NULL)
+  for (;;)
     {
+      struct dirent const *dp;
+      char const *entry;
+
+      errno = 0;
+      dp = readdir (dirp);
+      if (! dp)
+	break;
+
       /* Skip "", ".", and "..".  "" is returned by at least one buggy
          implementation: Solaris 2.4 readdir on NFS file systems.  */
-      char const *entry = dp->d_name;
+      entry = dp->d_name;
       if (entry[entry[0] != '.' ? 0 : entry[1] != '.' ? 1 : 2] != '\0')
 	{
 	  size_t entry_size = strlen (entry) + 1;