From: Pedro Algarvio <pedro@algarvio.me>
Date: Sun, 10 Jun 2007 21:14:38 +0000 (+0000)
Subject: Fixed de-pluralization bug introduced in [85] regarding the extraction of translator... 
X-Git-Tag: 1.0~544
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=566ede2af0f16ed439cbc93b646e619b7bcf0a7e;p=thirdparty%2Fbabel.git

Fixed de-pluralization bug introduced in [85] regarding the extraction of translator comments.
Added a unittest which tests the extraction of translator comments that have non-translator comments right before the comment tag.
---

diff --git a/babel/messages/extract.py b/babel/messages/extract.py
index be468176..2c74529e 100644
--- a/babel/messages/extract.py
+++ b/babel/messages/extract.py
@@ -296,8 +296,8 @@ def extract_python(fileobj, keywords, comment_tags, options):
             if in_translator_comments is True:
                 translator_comments.append(value[1:].strip())
                 continue
-            for comment_tags in comment_tags:
-                if comment_tags in value:
+            for comment_tag in comment_tags:
+                if comment_tag in value:
                     if in_translator_comments is not True:
                         in_translator_comments = True
                     translator_comments.append(value[1:].strip())
diff --git a/babel/messages/tests/extract.py b/babel/messages/tests/extract.py
index 6a867225..4dea8dbe 100644
--- a/babel/messages/tests/extract.py
+++ b/babel/messages/tests/extract.py
@@ -39,6 +39,19 @@ msg = _(u'Foo Bar')
 # NOTE: A translation comment
 # with a second line
 msg = _(u'Foo Bar')
+""")
+        messages = list(extract.extract_python(buf, ('_',), ['NOTE'], {}))
+        self.assertEqual('Foo Bar', messages[0][2])
+        self.assertEqual(['NOTE: A translation comment', 'with a second line'],
+                         messages[0][3])
+        
+    def test_translator_comments_with_previous_non_translator_comments(self):
+        buf = StringIO("""
+# This shouldn't be in the output
+# because it didn't start with a comment tag
+# NOTE: A translation comment
+# with a second line
+msg = _(u'Foo Bar')
 """)
         messages = list(extract.extract_python(buf, ('_',), ['NOTE'], {}))
         self.assertEqual('Foo Bar', messages[0][2])