From: Phil Sutter <phil@nwl.cc>
Date: Tue, 28 Nov 2017 15:49:58 +0000 (+0100)
Subject: link_gre6: Detect invalid encaplimit values
X-Git-Tag: v4.15.0~92
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=56708ae7c9535859223c5b68097b35bf0fae677c;p=thirdparty%2Fiproute2.git

link_gre6: Detect invalid encaplimit values

Looks like a typo: get_u8() returns 0 on success and -1 on error, so the
error checking here was ineffective.

Fixes: a11b7b71a6eba ("link_gre6: really support encaplimit option")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/ip/link_gre6.c b/ip/link_gre6.c
index 50c1b804c..0a82eaecf 100644
--- a/ip/link_gre6.c
+++ b/ip/link_gre6.c
@@ -372,7 +372,7 @@ get_failed:
 			} else {
 				__u8 uval;
 
-				if (get_u8(&uval, *argv, 0) < -1)
+				if (get_u8(&uval, *argv, 0))
 					invarg("invalid ELIM", *argv);
 				encap_limit = uval;
 				flags &= ~IP6_TNL_F_IGN_ENCAP_LIMIT;