From: Eric Leblond <eric@regit.org>
Date: Sun, 17 Mar 2019 19:50:29 +0000 (+0100)
Subject: af-packet: rename option 'no-percpu-hash'
X-Git-Tag: suricata-5.0.0-rc1~336
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=567b5ee1bc76896861341829864dcf65e608de3b;p=thirdparty%2Fsuricata.git

af-packet: rename option 'no-percpu-hash'
---

diff --git a/doc/userguide/capture-hardware/ebpf-xdp.rst b/doc/userguide/capture-hardware/ebpf-xdp.rst
index 799a52f8c5..837df357d6 100644
--- a/doc/userguide/capture-hardware/ebpf-xdp.rst
+++ b/doc/userguide/capture-hardware/ebpf-xdp.rst
@@ -260,13 +260,13 @@ also use the ``/etc/suricata/ebpf/xdp_filter.bpf`` (in our example TCP offloadin
     ring-size: 200000
     # Uncomment the following if you are using hardware XDP with
     # a card like Netronome
-    # no-percpu-hash: yes
+    # use-percpu-hash: no
 
 
-XDP bypass is compatible with AF_PACKET IPS mode. Packets from bypassed flows will be send directly 
-from one card to the second card without going by the kernel network stack.
+XDP bypass is compatible with AF_PACKET IPS mode. Packets from bypassed flows will be send directly
+from one card to the second card without going by the ker nel network stack.
 
-If you are using hardware XDP offload you may have to use the ``no-percpu-hash`` function and
+If you are using hardware XDP offload you may have to set ``use-percpu-hash`` to false and
 build and install the XDP filter file after setting ``USE_PERCPU_HASH`` to 0.
 
 Intel NIC setup
diff --git a/src/runmode-af-packet.c b/src/runmode-af-packet.c
index 9d743aa6dc..0fc4ee6472 100644
--- a/src/runmode-af-packet.c
+++ b/src/runmode-af-packet.c
@@ -507,8 +507,9 @@ static void *ParseAFPConfig(const char *iface)
             }
         }
 
-        if (ConfGetChildValueBoolWithDefault(if_root, if_default, "no-percpu-hash", (int *)&boolval) == 1) {
-            if (boolval) {
+        boolval = true;
+        if (ConfGetChildValueBoolWithDefault(if_root, if_default, "use-percpu-hash", (int *)&boolval) == 1) {
+            if (boolval == false) {
                 SCLogConfig("Not using percpu hash on iface %s",
                         aconf->iface);
                 aconf->ebpf_t_config.cpus_count = 1;