From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Wed, 15 Dec 2021 22:49:18 +0000 (+0900)
Subject: udev: refuse to process line when invalid program output is obtained
X-Git-Tag: v251-rc1~647^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=567c19a62ceb9fbc2b35980849270b26598f5a40;p=thirdparty%2Fsystemd.git

udev: refuse to process line when invalid program output is obtained
---

diff --git a/src/udev/udev-rules.c b/src/udev/udev-rules.c
index a610dea0d97..836a7789fb7 100644
--- a/src/udev/udev-rules.c
+++ b/src/udev/udev-rules.c
@@ -1848,9 +1848,13 @@ static int udev_rule_apply_token_to_event(
                 }
 
                 r = strv_split_newlines_full(&lines, result, EXTRACT_RETAIN_ESCAPE);
-                if (r < 0)
+                if (r == -ENOMEM)
+                        return log_oom();
+                if (r < 0) {
                         log_rule_warning_errno(dev, rules, r,
                                                "Failed to extract lines from result of command \"%s\", ignoring: %m", buf);
+                        return false;
+                }
 
                 STRV_FOREACH(line, lines) {
                         char *key, *value;