From: Victor Julien <vjulien@oisf.net>
Date: Tue, 20 Feb 2024 15:06:08 +0000 (+0100)
Subject: detect/address: avoid cppcheck false positive
X-Git-Tag: suricata-7.0.4~27
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=56915b2cc1d69c20807569946b01f3948e04c7a5;p=thirdparty%2Fsuricata.git

detect/address: avoid cppcheck false positive

src/detect-engine-address.c:1386:5: error: Memory leak: map.string [memleak]
    return true;
    ^

Seems cppcheck looses track of the pointer after the unnecessary cast to
void.

Bug: #6527.
(cherry picked from commit 78703bbc865a1dd15a1ae1c4c996b0150096ed0e)
---

diff --git a/src/detect-engine-address.c b/src/detect-engine-address.c
index f0d425b2bc..191e8f504d 100644
--- a/src/detect-engine-address.c
+++ b/src/detect-engine-address.c
@@ -1377,7 +1377,7 @@ static bool DetectAddressMapAdd(DetectEngineCtx *de_ctx, const char *string,
     map->address = address;
     map->contains_negation = contains_negation;
 
-    if (HashListTableAdd(de_ctx->address_table, (void *)map, 0) != 0) {
+    if (HashListTableAdd(de_ctx->address_table, map, 0) != 0) {
         SCFree(map->string);
         SCFree(map);
         return false;