From: Daniel P. Berrange <berrange@redhat.com>
Date: Thu, 30 Jun 2011 14:01:54 +0000 (+0100)
Subject: Fix use of uninitialized memory when releasing PCI slots
X-Git-Tag: v0.9.3~38
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=56a77b4920e2a1e027be9f133fab469599864bc9;p=thirdparty%2Flibvirt.git

Fix use of uninitialized memory when releasing PCI slots

The 'function' field in the PCI address was not correctly
initialized, so it was building the wrong address address
string and so not removing all functions from the in use
list.

* src/qemu/qemu_command.c: Fix initialization of PCI function
---

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 7ac1faf9f5..90a6653d6f 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -931,14 +931,14 @@ int qemuDomainPCIAddressReleaseSlot(qemuDomainPCIAddressSetPtr addrs, int slot)
 {
     virDomainDeviceInfo dev;
     char *addr;
-    int function;
     int ret = 0;
+    unsigned int *function = &dev.addr.pci.function;
 
     dev.addr.pci.domain = 0;
     dev.addr.pci.bus = 0;
     dev.addr.pci.slot = slot;
 
-    for (function = 0; function <= QEMU_PCI_ADDRESS_LAST_FUNCTION; function++) {
+    for (*function = 0; *function <= QEMU_PCI_ADDRESS_LAST_FUNCTION; (*function)++) {
         addr = qemuPCIAddressAsString(&dev);
         if (!addr)
             return -1;
@@ -950,7 +950,7 @@ int qemuDomainPCIAddressReleaseSlot(qemuDomainPCIAddressSetPtr addrs, int slot)
 
         VIR_FREE(addr);
 
-        if (qemuDomainPCIAddressReleaseFunction(addrs, slot, function) < 0)
+        if (qemuDomainPCIAddressReleaseFunction(addrs, slot, *function) < 0)
             ret = -1;
     }