From: Michal Nowak <mnowak@isc.org>
Date: Mon, 29 Jun 2026 11:41:57 +0000 (+0000)
Subject: Assert current_version in qpzone_destroy()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=56c24cef21e7b78c35ac51a19aae018416bf65d5;p=thirdparty%2Fbind9.git

Assert current_version in qpzone_destroy()

current_version is a lifetime invariant and never NULL.  Assert it to
silence a scan-build false positive:

    lib/dns/qpzone.c:593:2: warning: Dereference of null pointer [core.NullDereference]

Assisted-by: Claude:claude-opus-4-8
---

diff --git a/lib/dns/qpzone.c b/lib/dns/qpzone.c
index 02353d878da..23749db8b3f 100644
--- a/lib/dns/qpzone.c
+++ b/lib/dns/qpzone.c
@@ -586,6 +586,7 @@ free_db_rcu(struct rcu_head *rcu_head) {
 static void
 qpzone_destroy(qpzonedb_t *qpdb) {
 	REQUIRE(qpdb->future_version == NULL);
+	REQUIRE(qpdb->current_version != NULL);
 
 	isc_refcount_decrementz(&qpdb->current_version->references);