From: Luca Boccassi Date: Fri, 25 Mar 2022 18:40:31 +0000 (+0000) Subject: mount-copybind: fix shellcheck warning X-Git-Tag: lucaceresoli/bug-15201-perf-libtraceevent-missing~4617 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=56c7962a6c31acfe0e118f713954aeafd7e2d9c0;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git mount-copybind: fix shellcheck warning $ shellcheck meta/recipes-core/volatile-binds/files/mount-copybind In meta/recipes-core/volatile-binds/files/mount-copybind line 54: mountcontext=",rootcontext=$(matchpathcon -n $mountpoint)" ^---------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: mountcontext=",rootcontext=$(matchpathcon -n "$mountpoint")" For more information: https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... Signed-off-by: Luca Boccassi Signed-off-by: Alexandre Belloni --- diff --git a/meta/recipes-core/volatile-binds/files/mount-copybind b/meta/recipes-core/volatile-binds/files/mount-copybind index aad022c6e4c..8bbb406b3a0 100755 --- a/meta/recipes-core/volatile-binds/files/mount-copybind +++ b/meta/recipes-core/volatile-binds/files/mount-copybind @@ -48,7 +48,7 @@ if [ -d "$mountpoint" ]; then # If that fails, fall back to slower copy. if command -v selinuxenabled > /dev/null 2>&1; then if selinuxenabled; then - mountcontext=",rootcontext=$(matchpathcon -n $mountpoint)" + mountcontext=",rootcontext=$(matchpathcon -n "$mountpoint")" fi fi if ! mount -t overlay overlay -olowerdir="$mountpoint",upperdir="$spec",workdir="$overlay_workdir""$mountcontext" "$mountpoint" > /dev/null 2>&1; then