From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 3 Apr 2024 14:46:09 +0000 (+0200)
Subject: resolved: return ExpectedMore error if we require "more" varlink flag on method call
X-Git-Tag: v256-rc1~323
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=56efc39fbc4fadaada40f382212a45b85f10dcc0;p=thirdparty%2Fsystemd.git

resolved: return ExpectedMore error if we require "more" varlink flag on method call

Fixes: #32066
---

diff --git a/src/resolve/resolved-varlink.c b/src/resolve/resolved-varlink.c
index 6b835904be1..25f85d82331 100644
--- a/src/resolve/resolved-varlink.c
+++ b/src/resolve/resolved-varlink.c
@@ -1238,7 +1238,7 @@ static int vl_method_subscribe_query_results(Varlink *link, JsonVariant *paramet
 
         /* if the client didn't set the more flag, it is using us incorrectly */
         if (!FLAGS_SET(flags, VARLINK_METHOD_MORE))
-                return varlink_error_invalid_parameter(link, NULL);
+                return varlink_error(link, VARLINK_ERROR_EXPECTED_MORE, NULL);
 
         if (json_variant_elements(parameters) > 0)
                 return varlink_error_invalid_parameter(link, parameters);