From: Jason Merrill <jason@redhat.com>
Date: Thu, 13 Jun 2024 01:43:45 +0000 (-0400)
Subject: c++: adjust comment
X-Git-Tag: basepoints/gcc-16~8258
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=57113e3db168e19c46ca52ad084790d462eea603;p=thirdparty%2Fgcc.git

c++: adjust comment

Adjusting the comment I added in r15-1223 to clarify that this is a
workaround for a bug elsewhere.

gcc/cp/ChangeLog:

	* module.cc (depset::hash::add_binding_entity): Adjust comment.
---

diff --git a/gcc/cp/module.cc b/gcc/cp/module.cc
index 72e876cec18..ea7ad0c1f29 100644
--- a/gcc/cp/module.cc
+++ b/gcc/cp/module.cc
@@ -13254,9 +13254,10 @@ depset::hash::add_binding_entity (tree decl, WMB_Flags flags, void *data_)
       if (data->hash->add_namespace_entities (decl, data->partitions))
 	{
 	  /* It contains an exported thing, so it is exported.
-	     We used to assert DECL_MODULE_PURVIEW_P, but that fails for a
-	     namespace like std::__exception_ptr which is never opened in
-	     module purview; the exporting using finds another using.  */
+
+	     FIXME we have to set DECL_MODULE_PURVIEW_P instead of asserting
+	     that it is already set because of the c++/114683 issue with
+	     exported using-declarations; see do_nonmember_using_decl.  */
 	  DECL_MODULE_PURVIEW_P (decl) = true;
 	  DECL_MODULE_EXPORT_P (decl) = true;
 	}