From: Chen Ni Date: Mon, 19 Jan 2026 06:35:07 +0000 (+0800) Subject: powerpc/44x/uic: Consolidate chained IRQ handler install/remove X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5716cacebac887b45091c658caa6d1ea25c238dc;p=thirdparty%2Fkernel%2Flinux.git powerpc/44x/uic: Consolidate chained IRQ handler install/remove The driver currently sets the handler data and the chained handler in two separate steps. This creates a theoretical race window where an interrupt could fire after the handler is set but before the data is assigned, leading to a NULL pointer dereference. Replace the two calls with irq_set_chained_handler_and_data() to set both the handler and its data atomically under the irq_desc->lock. Signed-off-by: Chen Ni Signed-off-by: Madhavan Srinivasan Link: https://patch.msgid.link/20260119063507.940782-1-nichen@iscas.ac.cn --- diff --git a/arch/powerpc/platforms/44x/uic.c b/arch/powerpc/platforms/44x/uic.c index cf4fc5263c89e..3f90126a90569 100644 --- a/arch/powerpc/platforms/44x/uic.c +++ b/arch/powerpc/platforms/44x/uic.c @@ -309,8 +309,8 @@ void __init uic_init_tree(void) cascade_virq = irq_of_parse_and_map(np, 0); - irq_set_handler_data(cascade_virq, uic); - irq_set_chained_handler(cascade_virq, uic_irq_cascade); + irq_set_chained_handler_and_data(cascade_virq, + uic_irq_cascade, uic); /* FIXME: setup critical cascade?? */ }