From: Karel Zak <kzak@redhat.com>
Date: Mon, 29 Nov 2021 14:26:49 +0000 (+0100)
Subject: utmpdump: don't ignore sscanf() return code [coverity scan]
X-Git-Tag: v2.38-rc1~129
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=573f4cc9404e1bee82402d498d26f39e438399ba;p=thirdparty%2Futil-linux.git

utmpdump: don't ignore sscanf() return code [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/login-utils/utmpdump.c b/login-utils/utmpdump.c
index 274f0d97aa..a0ff2b170d 100644
--- a/login-utils/utmpdump.c
+++ b/login-utils/utmpdump.c
@@ -282,7 +282,12 @@ static void undump(FILE *in, FILE *out)
 	while (fgets(linestart, 1023, in)) {
 		line = linestart;
 		memset(&ut, '\0', sizeof(ut));
-		sscanf(line, "[%hd] [%d] [%4c] ", &ut.ut_type, &ut.ut_pid, ut.ut_id);
+
+		if (sscanf(line, "[%hd] [%d] [%4c] ",
+				&ut.ut_type, &ut.ut_pid, ut.ut_id) != 3) {
+			warnx(_("parse error: %s"), line);
+			continue;
+		}
 
 		line += 19;
 		line += gettok(line, ut.ut_user, sizeof(ut.ut_user), 1);