From: Pablo Neira Ayuso Date: Wed, 15 Jun 2016 11:41:06 +0000 (+0200) Subject: tests: stricter string attribute validation X-Git-Tag: libnftnl-1.0.7~75 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=57468cfa7916aa6e21c977d1ddb6d0a0ad27edf7;p=thirdparty%2Flibnftnl.git tests: stricter string attribute validation In nft-expr_lookup-test.c, check for the strings instead of size. Signed-off-by: Pablo Neira Ayuso --- diff --git a/tests/nft-expr_lookup-test.c b/tests/nft-expr_lookup-test.c index 83fa8298..d3b45df4 100644 --- a/tests/nft-expr_lookup-test.c +++ b/tests/nft-expr_lookup-test.c @@ -30,18 +30,15 @@ static void print_err(const char *msg) static void cmp_nftnl_expr(struct nftnl_expr *rule_a, struct nftnl_expr *rule_b) { - uint32_t data_lena, data_lenb; - if (nftnl_expr_get_u32(rule_a, NFTNL_EXPR_LOOKUP_SREG) != nftnl_expr_get_u32(rule_b, NFTNL_EXPR_LOOPUP_SREG)) print_err("Expr NFTNL_EXPR_LOOkUP_SREG mismatches"); if (nftnl_expr_get_u32(rule_a, NFTNL_EXPR_LOOKUP_DREG) != nftnl_expr_get_u32(rule_b, NFTNL_EXPR_LOOPUP_DREG)) print_err("Expr NFTNL_EXPR_LOOkUP_DREG mismatches"); - nftnl_expr_get(rule_a, NFTNL_EXPR_LOOKUP_SET, &data_lena); - nftnl_expr_get(rule_b, NFTNL_EXPR_LOOKUP_SET, &data_lenb); - if (data_lena != data_lenb) - print_err("Expr NFTNL_EXPR_LOOKUP_SET size mismatches"); + if (strcmp(nftnl_expr_get_str(rule_a, NFTNL_EXPR_LOOKUP_SET), + nftnl_expr_get_str(rule_b, NFTNL_EXPR_LOOKUP_SET))) + print_err("Expr NFTNL_EXPR_LOOKUP_SET mismatches"); } int main(int argc, char *argv[])