From: Richard Purdie <richard.purdie@linuxfoundation.org>
Date: Fri, 1 Jul 2022 11:51:59 +0000 (+0100)
Subject: insane: Reword staging to refer to populate_sysroot
X-Git-Tag: lucaceresoli/bug-15201-perf-libtraceevent-missing~3599
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=5753b6bc5b106ab5fd3652c24ef6a1f94f983424;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git

insane: Reword staging to refer to populate_sysroot

'staging' is a term lost in time. This code now operates on the sysroots,
adjust the naming and messages to be more correct/appropriate.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 746a13c27b1..e571d72e183 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -1151,13 +1151,14 @@ python do_package_qa_setscene () {
 }
 addtask do_package_qa_setscene
 
-python do_qa_staging() {
-    bb.note("QA checking staging")
+python do_qa_sysroot() {
+    bb.note("QA checking do_populate_sysroot")
     sysroot_destdir = d.expand('${SYSROOT_DESTDIR}')
     for sysroot_dir in d.expand('${SYSROOT_DIRS}').split():
         qa_check_staged(sysroot_destdir + sysroot_dir, d)
-    oe.qa.exit_with_message_if_errors("QA staging was broken by the package built above", d)
+    oe.qa.exit_with_message_if_errors("do_populate_sysroot for this recipe installed files with QA issues", d)
 }
+do_populate_sysroot[postfuncs] += "do_qa_sysroot"
 
 python do_qa_patch() {
     import subprocess
@@ -1349,10 +1350,6 @@ python do_qa_unpack() {
     unpack_check_src_uri(d.getVar('PN'), d)
 }
 
-# The Staging Func, to check all staging
-#addtask qa_staging after do_populate_sysroot before do_build
-do_populate_sysroot[postfuncs] += "do_qa_staging "
-
 # Check for patch fuzz
 do_patch[postfuncs] += "do_qa_patch "