From: Jason Kirtland <jek@discorporate.us>
Date: Mon, 8 Oct 2007 18:19:02 +0000 (+0000)
Subject: - Cleaned up visit_insert a bit, inserts are ~3% faster now.
X-Git-Tag: rel_0_4_0~53
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=57a7a52b566507f9126998a0c62b30a55affae2f;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

- Cleaned up visit_insert a bit, inserts are ~3% faster now.
---

diff --git a/lib/sqlalchemy/sql/compiler.py b/lib/sqlalchemy/sql/compiler.py
index 50664db16f..572955806a 100644
--- a/lib/sqlalchemy/sql/compiler.py
+++ b/lib/sqlalchemy/sql/compiler.py
@@ -606,13 +606,16 @@ class DefaultCompiler(engine.Compiled, visitors.ClauseVisitor):
         return None
 
     def visit_insert(self, insert_stmt):
-
         self.isinsert = True
         colparams = self._get_colparams(insert_stmt)
+        preparer = self.preparer
 
-        return ("INSERT INTO " + self.preparer.format_table(insert_stmt.table) + " (" + string.join([self.preparer.format_column(c[0]) for c in colparams], ', ') + ")" +
-         " VALUES (" + string.join([c[1] for c in colparams], ', ') + ")")
-
+        return ("INSERT INTO %s (%s) VALUES (%s)" %
+                (preparer.format_table(insert_stmt.table),
+                 ', '.join([preparer.format_column(c[0])
+                            for c in colparams]),
+                 ', '.join([c[1] for c in colparams])))
+    
     def visit_update(self, update_stmt):
         self.stack.append({'from':util.Set([update_stmt.table])})